-
Notifications
You must be signed in to change notification settings - Fork 7
WIP: new oauth plugin for NBS to replace backend plugin #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a lot but it seems functional and is essentially in an alpha state to start, so let's ship and continue to iterate if things come up.
I agree it was a ton of stuff to figure out so I'm sure things will come up, but I will make sure to keep an eye out to address, and i'm sure this will become a bit more user friendly once we merge the NFS PR. |
I figured it would be easier/better to incorporate this into a new module so that we can still serve the old legacy backend plugin in the mean-time.
This allows us to use coder as a sign in provider, or a resource provider depending on how the user incorporates it into backstage.
There is minimal setup for the plugin itself, but its a few more steps for the frontend inserts, but this will be minimized when we update the frontend plugin for the NFS in the other PR #149
Let me know if this aligns with what we are looking for, but I think this should be ideal for what the customer was looking for.